lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak
    Date
    kfree should be called to free resource in error path
    before return.

    Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
    ---
    drivers/clocksource/timer-imx-gpt.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c
    index a3d6ccb..0f78b30 100644
    --- a/drivers/clocksource/timer-imx-gpt.c
    +++ b/drivers/clocksource/timer-imx-gpt.c
    @@ -477,12 +477,16 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t
    return -ENOMEM;

    imxtm->base = of_iomap(np, 0);
    - if (!imxtm->base)
    + if (!imxtm->base) {
    + kfree(imxtm);
    return -ENXIO;
    + }

    imxtm->irq = irq_of_parse_and_map(np, 0);
    - if (imxtm->irq <= 0)
    + if (imxtm->irq <= 0) {
    + kfree(imxtm);
    return -EINVAL;
    + }

    imxtm->clk_ipg = of_clk_get_by_name(np, "ipg");

    --
    2.7.4
    \
     
     \ /
      Last update: 2018-11-05 02:11    [W:3.028 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site