Messages in this thread | | | Subject | Re: may I ignore "net/core/rtnetlink.c:3156:1: warning: the frame size of 1280 bytes ..."? | From | Joe Perches <> | Date | Sun, 04 Nov 2018 09:15:45 -0800 |
| |
On Sun, 2018-11-04 at 17:14 +0100, Toralf Förster wrote: > compiling recent kernel (4.18.x, 4.19.1) at my server I do still get : > > > net/core/rtnetlink.c: In function ‘rtnl_newlink’: > net/core/rtnetlink.c:3156:1: warning: the frame size of 1280 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > > with "gcc version 7.3.0 (Gentoo Hardened 7.3.0-r3 p1.4) " and do wonder whether it is safe to ignore it? >
This was introduce by a desire to eliminate variable length array declarations by
commit ccf8dbcd062a930e64741c939ca784d15316aa0c Author: Kees Cook < keescook@chromium.org> Date: Wed May 30 15:20:52 2018 -0700
rtnetlink: Remove VLA usage
It does make the stack use here unfortunately obviously large, but it could have been this large, just unreported.
Perhaps no obvious solution here as an alloc instead of stack use may be costly.
| |