Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up | Date | Fri, 2 Nov 2018 21:55:35 +0000 |
| |
> -----Original Message----- > From: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> > Sent: Thursday, November 1, 2018 11:57 AM > To: Dexuan Cui <decui@microsoft.com> > Cc: Michael Kelley <mikelley@microsoft.com>; KY Srinivasan > <kys@microsoft.com>; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; > jasowang@redhat.com; Stephen Hemminger <sthemmin@microsoft.com>; > vkuznets <vkuznets@redhat.com>; Sasha Levin > <Alexander.Levin@microsoft.com>; Haiyang Zhang > <haiyangz@microsoft.com>; Stable@vger.kernel.org > Subject: Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused > by incorrect clean-up > > On Wed, Oct 31, 2018 at 11:23:54PM +0000, Dexuan Cui wrote: > > > From: Michael Kelley <mikelley@microsoft.com> > > > Sent: Wednesday, October 24, 2018 08:38 > > > From: kys@linuxonhyperv.com <kys@linuxonhyperv.com> Sent: > Wednesday, > > > October 17, 2018 10:10 PM > > > > From: Dexuan Cui <decui@microsoft.com> > > > > > > > > In kvp_send_key(), we do need call process_ib_ipinfo() if > > > > message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it > turns out > > > > the userland hv_kvp_daemon needs the info of operation, adapter_id > and > > > > addr_family. With the incorrect fc62c3b1977d, the host can't get the > > > > VM's IP via KVP. > > > > > > > > And, fc62c3b1977d added a "break;", but actually forgot to initialize > > > > the key_size/value in the case of KVP_OP_SET, so the default key_size > of > > > > 0 is passed to the kvp daemon, and the pool files > > > > /var/lib/hyperv/.kvp_pool_* can't be updated. > > > > > > > > This patch effectively rolls back the previous fc62c3b1977d, and > > > > correctly fixes the "this statement may fall through" warnings. > > > > > > > > This patch is tested on WS 2012 R2 and 2016. > > > > > > > > Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall > > > through" warnings") > > > > Signed-off-by: Dexuan Cui <decui@microsoft.com> > > > > Cc: K. Y. Srinivasan <kys@microsoft.com> > > > > Cc: Haiyang Zhang <haiyangz@microsoft.com> > > > > Cc: Stephen Hemminger <sthemmin@microsoft.com> > > > > Cc: <Stable@vger.kernel.org> > > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > > > > --- > > > > drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- > > > > 1 file changed, 22 insertions(+), 4 deletions(-) > > > > > > > Reviewed-by: Michael Kelley <mikelley@microsoft.com> > > > > Hi Greg, > > Can you please take a look at this patch?
Greg,
I have already signed-off on this patch.
K. Y > > Nope, I'm not the hv maintainer, they need to look at this and ack it, > not me :) > > greg k-h
| |