lkml.org 
[lkml]   [2018]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*
> +		/*
> + * dma_sync_sg_*() flush the physical pages, so point
> + * sg->dma_address to the physical ones for the right behavior.
> + */
> + for_each_sg(msm_obj->sgt->sgl, s, msm_obj->sgt->nents, i)
> + sg_dma_address(s) = sg_phys(s);
> +

I'm sorry, but this is completely bogus and not acceptable.

The only place that is allowed to initialize sg_dma_address is
dma_map_sg. If the default dma ops don't work for your setup we have
major a problem and need to fix the dma api / iommu integration instead
of hacking around it.

\
 
 \ /
  Last update: 2018-11-28 08:41    [W:0.102 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site