Messages in this thread | | | Date | Tue, 27 Nov 2018 23:05:24 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH] sis5513: fix potential use after free |
| |
On Wed, Nov 28, 2018 at 08:55:26AM +0800, Pan Bian wrote: > The function sis_find_family drops lpc_bridge reference via pci_dev_put, > however, after that, field lpc_bridge->revision is read. This may result > in a use after free bug. The patch moves the put operation after the > condition check. > > Signed-off-by: Pan Bian <bianpan2016@163.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |