Messages in this thread | | | From | Enric Balletbo i Serra <> | Subject | [PATCH v3 0/8] mfd / platform: cros_ec: move cros_ec sysfs attributes to its own drivers. | Date | Tue, 27 Nov 2018 13:18:41 +0100 |
| |
Hi,
This is quick respin of the previous version because I introduced a build problem between patch 3 and 6 due a wrong squash on my side. Sorry about that. I also take this opportunity to do some few cleanups.
This is another patchset to try to cleanup a bit more the crossed references for cros-ec driver between the MFD and the platform/chrome subsystems.
The purpose of these patches is get rid of the different cros-ec attributes from mfd/cros_ec_dev to its own sub-driver in platform/chrome. cros_ec_dev continues instantiating the sub-devices but the sysfs attributes are owned by the platform driver.E.g. The lightbar driver should own his sysfs attributes and be instantiated only if the Embedded Controller has a lightbar.
The patchset also adds the documentation of the sysfs attributes.
Most of the patches touches mfd subsystem and platform/chrome so I'd suggest go all using and inmutable branch.
Waiting for your feedback. Best regards, Enric
Changes in v3: - Removed cros_ec_remove from include file. - Removed unneded check for ec_dev. - Fixed build error as reported by the kbuild test robot. - Do not print ec_platform name as is with dev_err is enough.
Changes in v2: - Use devm only for the cros-ec core. - Removed the two exported functions to attach/detach to the cros_class. - Create the attributes directly instead of use the attach/detach callbacks. - Add a "default MFD_CROS_EC_CHARDEV" in Kconfig for this. - Removed the checks for missing debug_info, are not needed now. - Removed a comment that no longer applies. - Removed unnecessary IS_ENABLED. - Removed dev_err message telling that VBC is found. - Use dev_warn instead of dev_err as the error is ignored. - Removed ec_with_lightbar variable. - Fix WARN when unloading. This is new in these series.
Enric Balletbo i Serra (8): mfd / platform: cros_ec: use devm_mfd_add_devices. mfd / platform: cros_ec: move lightbar attributes to its own driver. mfd / platform: cros_ec: move vbc attributes to its own driver. mfd / platform: cros_ec: move debugfs attributes to its own driver. mfd / platform: cros_ec: move device sysfs attributes to its own driver. mfd / platform: cros_ec: instantiate only if th EC has a VBC NVRAM. platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar. mfd: cros_ec: add a dev_release empty method.
.../ABI/testing/sysfs-class-chromeos | 32 +++++ ...sfs-class-chromeos-driver-cros-ec-lightbar | 74 ++++++++++ .../sysfs-class-chromeos-driver-cros-ec-vbc | 6 + drivers/mfd/Kconfig | 1 - drivers/mfd/cros_ec.c | 14 +- drivers/mfd/cros_ec_dev.c | 93 +++++-------- drivers/mfd/cros_ec_dev.h | 6 - drivers/platform/chrome/Kconfig | 45 ++++++- drivers/platform/chrome/Makefile | 7 +- drivers/platform/chrome/cros_ec_debugfs.c | 62 ++++++--- drivers/platform/chrome/cros_ec_i2c.c | 10 -- drivers/platform/chrome/cros_ec_lightbar.c | 126 ++++++++++++------ drivers/platform/chrome/cros_ec_lpc.c | 4 - drivers/platform/chrome/cros_ec_spi.c | 11 -- drivers/platform/chrome/cros_ec_sysfs.c | 36 ++++- drivers/platform/chrome/cros_ec_vbc.c | 59 +++++--- include/linux/mfd/cros_ec.h | 21 --- 17 files changed, 400 insertions(+), 207 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-class-chromeos create mode 100644 Documentation/ABI/testing/sysfs-class-chromeos-driver-cros-ec-lightbar create mode 100644 Documentation/ABI/testing/sysfs-class-chromeos-driver-cros-ec-vbc
-- 2.19.1
| |