lkml.org 
[lkml]   [2018]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 42/70] fs/exofs: fix potential memory leak in mount option parsing
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 515f1867addaba49c1c6ac73abfaffbc192c1db4 ]

    There are some cases can cause memory leak when parsing
    option 'osdname'.

    Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/exofs/super.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/fs/exofs/super.c b/fs/exofs/super.c
    index b795c567b5e1..360ba74e04e6 100644
    --- a/fs/exofs/super.c
    +++ b/fs/exofs/super.c
    @@ -100,6 +100,7 @@ static int parse_options(char *options, struct exofs_mountopt *opts)
    token = match_token(p, tokens, args);
    switch (token) {
    case Opt_name:
    + kfree(opts->dev_name);
    opts->dev_name = match_strdup(&args[0]);
    if (unlikely(!opts->dev_name)) {
    EXOFS_ERR("Error allocating dev_name");
    @@ -868,8 +869,10 @@ static struct dentry *exofs_mount(struct file_system_type *type,
    int ret;

    ret = parse_options(data, &opts);
    - if (ret)
    + if (ret) {
    + kfree(opts.dev_name);
    return ERR_PTR(ret);
    + }

    if (!opts.dev_name)
    opts.dev_name = dev_name;
    --
    2.17.1


    \
     
     \ /
      Last update: 2018-11-26 12:25    [W:4.069 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site