lkml.org 
[lkml]   [2018]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH 1/3] mm: Check if mmu notifier callbacks are allowed to fail
    Date
    Am 22.11.18 um 17:51 schrieb Daniel Vetter:
    > Just a bit of paranoia, since if we start pushing this deep into
    > callchains it's hard to spot all places where an mmu notifier
    > implementation might fail when it's not allowed to.
    >
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > Cc: Michal Hocko <mhocko@suse.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Rientjes <rientjes@google.com>
    > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    > Cc: "Jérôme Glisse" <jglisse@redhat.com>
    > Cc: linux-mm@kvack.org
    > Cc: Paolo Bonzini <pbonzini@redhat.com>
    > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

    Acked-by: Christian König <christian.koenig@amd.com>

    > ---
    > mm/mmu_notifier.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
    > index 5119ff846769..59e102589a25 100644
    > --- a/mm/mmu_notifier.c
    > +++ b/mm/mmu_notifier.c
    > @@ -190,6 +190,8 @@ int __mmu_notifier_invalidate_range_start(struct mm_struct *mm,
    > pr_info("%pS callback failed with %d in %sblockable context.\n",
    > mn->ops->invalidate_range_start, _ret,
    > !blockable ? "non-" : "");
    > + WARN(blockable,"%pS callback failure not allowed\n",
    > + mn->ops->invalidate_range_start);
    > ret = _ret;
    > }
    > }

    \
     
     \ /
      Last update: 2018-11-22 19:51    [W:2.876 / U:0.732 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site