lkml.org 
[lkml]   [2018]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 01/36] pinctrl: meson: fix pinconf bias disable
    Date
    From: Jerome Brunet <jbrunet@baylibre.com>

    [ Upstream commit e39f9dd8206ad66992ac0e6218ef1ba746f2cce9 ]

    If a bias is enabled on a pin of an Amlogic SoC, calling .pin_config_set()
    with PIN_CONFIG_BIAS_DISABLE will not disable the bias. Instead it will
    force a pull-down bias on the pin.

    Instead of the pull type register bank, the driver should access the pull
    enable register bank.

    Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
    Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
    Acked-by: Neil Armstrong <narmstrong@baylibre.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/meson/pinctrl-meson.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
    index 29a458da78db..4f3ab18636a3 100644
    --- a/drivers/pinctrl/meson/pinctrl-meson.c
    +++ b/drivers/pinctrl/meson/pinctrl-meson.c
    @@ -192,7 +192,7 @@ static int meson_pinconf_set(struct pinctrl_dev *pcdev, unsigned int pin,
    dev_dbg(pc->dev, "pin %u: disable bias\n", pin);

    meson_calc_reg_and_bit(bank, pin, REG_PULL, &reg, &bit);
    - ret = regmap_update_bits(pc->reg_pull, reg,
    + ret = regmap_update_bits(pc->reg_pullen, reg,
    BIT(bit), 0);
    if (ret)
    return ret;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-11-22 21:02    [W:3.620 / U:0.448 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site