lkml.org 
[lkml]   [2018]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] f2fs: read page index before freeing
On 11/22, Chao Yu wrote:
> Hi Pan,
>
> On 2018/11/22 18:58, Pan Bian wrote:
> > The function truncate_node frees the page with f2fs_put_page. However,
> > the page index is read after that. So, the patch reads the index before
> > freeing the page.
>
> Good catch!

+1

>
> It will be better to add:
>
> Fixes: bf39c00a9a7f ("f2fs: drop obsolete node page when it is truncated")
> Cc: <stable@vger.kernel.org>
>
> >
> > Signed-off-by: Pan Bian <bianpan2016@163.com>
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>

Done.

>
> Thanks,

\
 
 \ /
  Last update: 2018-11-22 13:03    [W:0.096 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site