lkml.org 
[lkml]   [2018]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/2] modpost: skip ELF local symbols by default during section mismatch check
Hello Masahiro,

On Wed, 21 Nov 2018, Masahiro Yamada wrote:

> I think this is almost good.
> Just a nit.
>
> Maybe, putting this check in secref_whitelist()
> (with a comment "Pattern 6:")
> could look more consistency.
>
>
> Also, if you use strstart() helper,
> you can remove is_local_symbol() function.
>
>
> /* Check for pattern 6 */
> if (strstarts(fromsym, ".L"))
> return 0;
>

Thank you for your suggestion. This change is a definite improvement.
The patch has been updated, and I will repost the patch after it's been
tested.

Best regards,

- Paul

\
 
 \ /
  Last update: 2018-11-21 18:53    [W:0.079 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site