lkml.org 
[lkml]   [2018]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED
On Tue, 20 Nov 2018 10:10:39 +0100,
Pavel Machek wrote:
>
> On Tue 2018-11-20 08:07:09, Takashi Iwai wrote:
> > On Tue, 20 Nov 2018 00:57:13 +0100,
> > Pavel Machek wrote:
> > >
> > > > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
> > > > +#include <linux/platform_data/x86/huawei_wmi.h>
> > > > +
> > > > +static int (*huawei_wmi_micmute_led_set_func)(bool);
> > > > +
> > >
> > > So we should not be doing this.
> > >
> > > Thinkpad ACPI module exports its LEDs there, for example.
> >
> > Both thinkpad_acpi and dell_laptop provide the interface to HD-audio
> > in the very same way like this.
>
> Not good :-(. Please don't add new ones, general purpose LEDs should
> really use LED subsystem.

What's the problem with this approach?


Takashi

\
 
 \ /
  Last update: 2018-11-20 10:24    [W:0.501 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site