lkml.org 
[lkml]   [2018]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] hwmon: (ntc_thermistor): add support for B57891S0103 from Epcos
On Mon, Nov 19, 2018 at 09:16:12PM +0000, Peter Rosin wrote:
> >
> > Guess I deserve the non-alphabetic order as penalty for not enforcing it
> > earlier. I'll accept the patch after DT approval and submit another one
> > myself afterwards to restore alphabetic order.
>
> Right, I'm thinking another good change would be to introduce an enum
> into the ntc_thermistor_id array, because the hard-coded numbering in

Yes, sounds like a good idea.

> the ntc_match variable is a bit fragile in my taste, and that list would
> also benefit from being alphabetic. Currently there's simply no way to
> add things in the middle without causing mayhem. I thought about doing
> that, but didn't want to waste energy doing it up front without knowing
> if it would be well received (the driver might have been superseded or

It would.

Guenter

> something). I'm glad that you have volunteered to clean things up.
> Ha! :-)
>
> Cheers,
> Peter
>
> > Guenter
> >
> >> };
> >>
> >> struct ntc_thermistor_platform_data {
> >> --
> >> 2.11.0
> >>
>

\
 
 \ /
  Last update: 2018-11-19 22:28    [W:0.377 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site