Messages in this thread | | | Subject | Re: [PATCH v3] usb: hub: add retry routine after intr URB submit error | From | Nicolas Saenz Julienne <> | Date | Tue, 20 Nov 2018 16:17:29 +0100 |
| |
Hi Oliver,
On Tue, 2018-11-20 at 15:57 +0100, Oliver Neukum wrote: > On Di, 2018-11-20 at 15:34 +0100, Nicolas Saenz Julienne wrote: > > The hub sends hot-plug events to the host trough it's interrupt > > URB. The > > driver takes care of completing the URB and re-submitting it. > > Completion > > errors are handled in the hub_event() work, yet submission errors > > are > > ignored, rendering the device unresponsive. All further events are > > lost. > > > > Hi, > > almost. There is no point in kicking of an error handling while aq > reset is underway. You are checking only "quiescing" but not > "in_reset".
Anytime "in_reset" is set "quiescing" is also set:
static int hub_pre_reset(struct usb_interface *intf) { struct usb_hub *hub = usb_get_intfdata(intf);
hub_quiesce(hub, HUB_PRE_RESET); //sets quiesce hub->in_reset = 1; hub_pm_barrier_for_all_ports(hub); return 0; }
static int hub_post_reset(struct usb_interface *intf) { struct usb_hub *hub = usb_get_intfdata(intf);
hub->in_reset = 0; hub_pm_barrier_for_all_ports(hub); hub_activate(hub, HUB_POST_RESET); //clears quiesce return 0; }
I should be OK isn't it?
Regards, Nicolas
> > Regards > Oliver >
[unhandled content-type:application/pgp-signature] | |