Messages in this thread | | | Date | Mon, 19 Nov 2018 21:22:07 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v8 01/13] arch/resctrl: Start renaming the rdt files to more generic names |
| |
On Mon, Nov 19, 2018 at 08:11:36PM +0000, Moger, Babu wrote: > Changed core.c and internel.h to res.c and res.h respectively. Both of > these files are about resource definitions and initialization.
I guess but the core.c thing we do a lot in the kernel:
$ git ls-files | grep -E "/core\.c" | wc -l 100
which denotes where the core functionality is located. res.c doesn't tell me that. res.h doesn't tell me either that it is an resctrl-internal header...
IOW, calling it core.c and internal.h gives you an additional information what those files contain. And I think that's useful.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |