lkml.org 
[lkml]   [2018]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 128/150] net: bcmgenet: Poll internal PHY for GENETv5
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Florian Fainelli <f.fainelli@gmail.com>

    [ Upstream commit 64bd9c8135751b561f27edaaffe93d07093f81af ]

    On GENETv5, there is a hardware issue which prevents the GENET hardware
    from generating a link UP interrupt when the link is operating at
    10Mbits/sec. Since we do not have any way to configure the link
    detection logic, fallback to polling in that case.

    Fixes: 421380856d9c ("net: bcmgenet: add support for the GENETv5 hardware")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/broadcom/genet/bcmmii.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
    +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
    @@ -321,9 +321,12 @@ int bcmgenet_mii_probe(struct net_device
    phydev->advertising = phydev->supported;

    /* The internal PHY has its link interrupts routed to the
    - * Ethernet MAC ISRs
    + * Ethernet MAC ISRs. On GENETv5 there is a hardware issue
    + * that prevents the signaling of link UP interrupts when
    + * the link operates at 10Mbps, so fallback to polling for
    + * those versions of GENET.
    */
    - if (priv->internal_phy)
    + if (priv->internal_phy && !GENET_IS_V5(priv))
    dev->phydev->irq = PHY_IGNORE_INTERRUPT;

    return 0;

    \
     
     \ /
      Last update: 2018-11-02 20:05    [W:4.167 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site