Messages in this thread | | | Date | Fri, 2 Nov 2018 11:38:13 +0800 | From | Feng Tang <> | Subject | Re: [PATCH 4.9 23/35] x86/mm: Expand static page table for fixmap space |
| |
Hi Ben,
On Thu, Nov 01, 2018 at 10:25:43PM +0000, Ben Hutchings wrote: > On Thu, 2018-10-11 at 17:35 +0200, Greg Kroah-Hartman wrote: > > 4.9-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Feng Tang <feng.tang@intel.com> > > > > commit 05ab1d8a4b36ee912b7087c6da127439ed0a903e upstream. > > This backport is incorrect. The part that updated __startup_64() in > arch/x86/kernel/head64.c was dropped, presumably because that function > doesn't exist in 4.9. However that seems to be an essential of the > fix. In 4.9 the startup_64 routine in arch/x86/kernel/head_64.S would > need to be changed instead. > > I also found that this introduces new boot-time warnings on some > systems if CONFIG_DEBUG_WX is enabled. > > So, unless someone provides fixes for those issues, I think this should > be reverted for the 4.9 branch.
Thanks for the catch, I'm fine with the revert for now.
- Feng
| |