Messages in this thread | | | From | Haiyang Zhang <> | Subject | RE: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up | Date | Thu, 1 Nov 2018 19:38:38 +0000 |
| |
> -----Original Message----- > From: kys@linuxonhyperv.com <kys@linuxonhyperv.com> > Sent: Thursday, October 18, 2018 1:10 AM > To: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; > jasowang@redhat.com; Stephen Hemminger <sthemmin@microsoft.com>; > Michael Kelley <mikelley@microsoft.com>; vkuznets <vkuznets@redhat.com> > Cc: Dexuan Cui <decui@microsoft.com>; KY Srinivasan <kys@microsoft.com>; > Haiyang Zhang <haiyangz@microsoft.com>; Stable@vger.kernel.org > Subject: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by > incorrect clean-up > > From: Dexuan Cui <decui@microsoft.com> > > In kvp_send_key(), we do need call process_ib_ipinfo() if > message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out > the userland hv_kvp_daemon needs the info of operation, adapter_id and > addr_family. With the incorrect fc62c3b1977d, the host can't get the VM's IP > via KVP. > > And, fc62c3b1977d added a "break;", but actually forgot to initialize the > key_size/value in the case of KVP_OP_SET, so the default key_size of > 0 is passed to the kvp daemon, and the pool files > /var/lib/hyperv/.kvp_pool_* can't be updated. > > This patch effectively rolls back the previous fc62c3b1977d, and correctly fixes > the "this statement may fall through" warnings. > > This patch is tested on WS 2012 R2 and 2016. > > Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall > through" warnings") > Signed-off-by: Dexuan Cui <decui@microsoft.com> > Cc: K. Y. Srinivasan <kys@microsoft.com> > Cc: Haiyang Zhang <haiyangz@microsoft.com> > Cc: Stephen Hemminger <sthemmin@microsoft.com> > Cc: <Stable@vger.kernel.org> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Thanks!
| |