lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 138/160] ext4: add missing brelse() in set_flexbg_block_bitmap()s error path
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vasily Averin <vvs@virtuozzo.com>

    commit cea5794122125bf67559906a0762186cf417099c upstream.

    Fixes: 33afdcc5402d ("ext4: add a function which sets up group blocks ...")
    Cc: stable@kernel.org # 3.3
    Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/resize.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/fs/ext4/resize.c
    +++ b/fs/ext4/resize.c
    @@ -442,16 +442,18 @@ static int set_flexbg_block_bitmap(struc

    BUFFER_TRACE(bh, "get_write_access");
    err = ext4_journal_get_write_access(handle, bh);
    - if (err)
    + if (err) {
    + brelse(bh);
    return err;
    + }
    ext4_debug("mark block bitmap %#04llx (+%llu/%u)\n", block,
    block - start, count2);
    ext4_set_bits(bh->b_data, block - start, count2);

    err = ext4_handle_dirty_metadata(handle, NULL, bh);
    + brelse(bh);
    if (unlikely(err))
    return err;
    - brelse(bh);
    }

    return 0;

    \
     
     \ /
      Last update: 2018-11-19 18:18    [W:2.418 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site