lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 82/90] ext4: fix buffer leak in ext4_xattr_move_to_block() on error path
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vasily Averin <vvs@virtuozzo.com>

    commit 6bdc9977fcdedf47118d2caf7270a19f4b6d8a8f upstream.

    Fixes: 3f2571c1f91f ("ext4: factor out xattr moving")
    Fixes: 6dd4ee7cab7e ("ext4: Expand extra_inodes space per ...")
    Reviewed-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Cc: stable@kernel.org # 2.6.23
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/xattr.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/fs/ext4/xattr.c
    +++ b/fs/ext4/xattr.c
    @@ -1489,6 +1489,8 @@ cleanup:
    kfree(buffer);
    if (is)
    brelse(is->iloc.bh);
    + if (bs)
    + brelse(bs->bh);
    kfree(is);
    kfree(bs);
    brelse(bh);

    \
     
     \ /
      Last update: 2018-11-19 18:09    [W:2.327 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site