Messages in this thread | | | Date | Mon, 19 Nov 2018 16:42:56 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v5 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend() |
| |
On Mon, Nov 19, 2018 at 09:22:32AM +0100, Roberto Sassu wrote: > On 11/18/2018 8:29 AM, Jarkko Sakkinen wrote: > > On Fri, Nov 16, 2018 at 04:55:36PM +0100, Roberto Sassu wrote: > > > I understood from a previous email that you want to include all API > > > changes for crypto agility in the same patch set. > > > > Hmm.. maybe there is some misunderstading. Can you point me to the > > comment? Thanks. > > --- > On Thu, Nov 08, 2018 at 03:24:46PM +0100, Roberto Sassu wrote: > > Should I include the patch for tpm_pcr_extend() in this patch set, even > > if the set fixes the digest size issue? > > Just add some note to the cover letter. Makes sense here to have a > prequel patch for that because otherwise the implementation will be > a bit messy and half-baked.
Ok, I guess it is OK as long as IMA (namely Mimi) gives that patch reviewed-by. It is not a huge change.
PS. I noticed that earlier patches have postfixes like '_struct' and '_ptr' for function arguments. Can you remove them in the next version?
/Jarkko
| |