lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Letux-kernel] [PATCH 0/5] gnss: sirf: add support for w2sg0004 + lna
    From
    Date
    Hi,

    > Am 18.11.2018 um 22:57 schrieb Andreas Kemnade <andreas@kemnade.info>:
    >
    > Here is another chapter of the story to get gta04 gnss power
    > management into the mainline kernel.
    > There is a w2sg0004 without wakeup line in there, so power state
    > can only be determined indirectly by looking at the serial data lines.
    > Then there as also an lna which needs to be powered for real gps
    > reception. That part needs probably more discussion, since it might
    > be an idea to have it more generalized since it has nothing todo
    > with the chip itself.

    On the other hand if we follow the "SoC is the spider in the net"
    way of looking at DTS hierarchy, we have the uart as a child of the
    SoC and the gnss receiver as a serdev child of the UART. The LNA
    is even one step more distantly connected to the gnss. So it makes
    sense to me to have it as a property/reference of the gnss chip's
    DTS record which is a sibling of the compatible records. So the only
    place where it can be reasonably processed is the driver.

    > I marked the corresponding patches as RFC. The support for
    > the w2sg0004 without wakeup can imho go in without the lna first
    > because users of that chip without an additional lna power supply
    > can already benefit from it if we should do more discussion first.
    > I just kept them together so that the full picture can be seen.
    >
    > Andreas Kemnade (5):
    > gnss: sirf: write data to gnss only when the gnss device is open
    > gnss: sirf: power on logic for devices without wakeup signal
    > dt-bindings: gnss: add w2sg0004 compatible string
    > gnss: sirf: add a separate supply for a lna
    > dt-bindings: gnss: add lna-supply property
    >
    > .../devicetree/bindings/gnss/sirfstar.txt | 2 +
    > drivers/gnss/sirf.c | 126 +++++++++++++++------
    > 2 files changed, 96 insertions(+), 32 deletions(-)
    >
    > --
    > 2.11.0
    >
    > _______________________________________________
    > http://projects.goldelico.com/p/gta04-kernel/
    > Letux-kernel mailing list
    > Letux-kernel@openphoenux.org
    > http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel

    BR,
    Nikolaus

    \
     
     \ /
      Last update: 2018-11-19 09:23    [W:3.859 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site