Messages in this thread | | | Date | Mon, 19 Nov 2018 09:36:32 -0800 (PST) | Subject | Re: [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h | From | Palmer Dabbelt <> |
| |
On Fri, 16 Nov 2018 19:09:36 PST (-0800), Olof Johansson wrote: > On Thu, Nov 8, 2018 at 11:32 AM Palmer Dabbelt <palmer@sifive.com> wrote: >> >> On Thu, 08 Nov 2018 11:07:00 PST (-0800), david.abdurachmanov@gmail.com wrote: >> > Fixes warning: 'struct module' declared inside parameter list will not be >> > visible outside of this definition or declaration >> > >> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com> >> > --- >> > arch/riscv/include/asm/module.h | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h >> > index 349df33808c4..cd2af4b013e3 100644 >> > --- a/arch/riscv/include/asm/module.h >> > +++ b/arch/riscv/include/asm/module.h >> > @@ -8,6 +8,7 @@ >> > >> > #define MODULE_ARCH_VERMAGIC "riscv" >> > >> > +struct module; >> > u64 module_emit_got_entry(struct module *mod, u64 val); >> > u64 module_emit_plt_entry(struct module *mod, u64 val); >> >> Works for me. Looks like arm64 might have exactly the same issue. I'll roll >> it up into the next RC. > > Looks like it's still here in -next. So, patch: > > Acked-by: Olof Johansson <olof@lixom.net> > > (and it'd be great to pickup together with the 32-bit build fix).
Sorry, I must have managed to screw something up here and drop both of these from my fixes list. Not sure how they managed to make it into -next without being in the list, but it's been on my TODO list to fix up my workflow scripts for a while anyway...
| |