lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 011/205] drm/nouveau/secboot/acr: fix memory leak
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>

    [ Upstream commit 74a07c0a59fa372b069d879971ba4d9e341979cf ]

    In case memory resources for *bl_desc* were allocated, release
    them before return.

    Addresses-Coverity-ID: 1472021 ("Resource leak")
    Fixes: 0d466901552a ("drm/nouveau/secboot/acr: Remove VLA usage")
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    Reviewed-by: John Hubbard <jhubbard@nvidia.com>
    Reviewed-by: Kees Cook <keescook@chromium.org>
    Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c
    +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c
    @@ -801,6 +801,7 @@ acr_r352_load(struct nvkm_acr *_acr, str
    bl = acr->hsbl_unload_blob;
    } else {
    nvkm_error(_acr->subdev, "invalid secure boot blob!\n");
    + kfree(bl_desc);
    return -EINVAL;
    }


    \
     
     \ /
      Last update: 2018-11-19 19:09    [W:4.043 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site