lkml.org 
[lkml]   [2018]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 079/124] ext4: avoid buffer leak on shutdown in ext4_mark_iloc_dirty()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vasily Averin <vvs@virtuozzo.com>

    commit a6758309a005060b8297a538a457c88699cb2520 upstream.

    ext4_mark_iloc_dirty() callers expect that it releases iloc->bh
    even if it returns an error.

    Fixes: 0db1ff222d40 ("ext4: add shutdown bit and check for it")
    Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Cc: stable@kernel.org # 4.11
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/inode.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/fs/ext4/inode.c
    +++ b/fs/ext4/inode.c
    @@ -5671,9 +5671,10 @@ int ext4_mark_iloc_dirty(handle_t *handl
    {
    int err = 0;

    - if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb))))
    + if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) {
    + put_bh(iloc->bh);
    return -EIO;
    -
    + }
    if (IS_I_VERSION(inode))
    inode_inc_iversion(inode);


    \
     
     \ /
      Last update: 2018-11-19 18:49    [W:4.103 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site