lkml.org 
[lkml]   [2018]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] net: phy: icplus: allow configuring the interrupt function on IP101GR
Hi Martin

> +static int ip101a_g_probe(struct phy_device *phydev)
> +{
> + struct device *dev = &phydev->mdio.dev;
> + struct ip101a_g_phy_priv *priv;
> +
> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> + if (!priv)
> + return -ENOMEM;
> +
> + if (device_property_read_bool(dev, "icplus,select-rx-error"))
> + priv->sel_intr32 = IP101GR_SEL_INTR32_RXER;
> + else if (device_property_read_bool(dev, "icplus,select-interrupt"))
> + priv->sel_intr32 = IP101GR_SEL_INTR32_INTR;
> + else
> + priv->sel_intr32 = IP101GR_SEL_INTR32_KEEP;

It would be good to return -EINVAL if both properties are found.

This looks good otherwise.

Andrew

\
 
 \ /
  Last update: 2018-11-18 18:14    [W:0.166 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site