lkml.org 
[lkml]   [2018]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH v2 11/25] net: cadence: switch to using nvmem_get_mac_address()
    Date
    On 13/11/2018 at 15:01, Bartosz Golaszewski wrote:
    > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    >
    > We now have a generalized helper routine to read the MAC address from
    > nvmem which takes struct device as argument. The nvmem subsystem will
    > then try device tree first before all other potential providers.
    >
    > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

    Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

    > ---
    > drivers/net/ethernet/cadence/macb_main.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
    > index 1d86b4d5645a..d9a208f7bb40 100644
    > --- a/drivers/net/ethernet/cadence/macb_main.c
    > +++ b/drivers/net/ethernet/cadence/macb_main.c
    > @@ -4055,7 +4055,7 @@ static int macb_probe(struct platform_device *pdev)
    > if (mac) {
    > ether_addr_copy(bp->dev->dev_addr, mac);
    > } else {
    > - err = of_get_nvmem_mac_address(np, bp->dev->dev_addr);
    > + err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr);
    > if (err) {
    > if (err == -EPROBE_DEFER)
    > goto err_out_free_netdev;
    >


    --
    Nicolas Ferre
    \
     
     \ /
      Last update: 2018-11-18 16:43    [W:2.773 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site