lkml.org 
[lkml]   [2018]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V3 2/7] net: lorawan: Add LoRaWAN socket module
David Miller <davem@davemloft.net> 於 2018年11月17日 週六 下午12:32寫道:
>
> From: Jian-Hong Pan <starnight@g.ncu.edu.tw>
> Date: Thu, 15 Nov 2018 00:01:23 +0800
>
> > +#define lrw_get_mac_cb(skb) ((struct lrw_mac_cb *)skb->cb)
>
> Please make this a static inline function. If the identifier is all lowercase
> programmers expect it to be real code not a CPP macro.

Okay! Sure

> > +#define LORAWAN_MODULE_NAME "lorawan"
> > +
> > +#define LRW_DBG_STR(fmt) LORAWAN_MODULE_NAME": "fmt
> > +#define lrw_info(fmt, ...) (pr_info(LRW_DBG_STR(fmt), ##__VA_ARGS__))
> > +#define lrw_dbg(fmt, ...) (pr_debug(LRW_DBG_STR(fmt), ##__VA_ARGS__))
>
> Just define "pr_fmt()" appropriately and you don't need to play these kinds
> of games.
>
> Set pr_fmt() and call pr_info() and pr_debug() directly.

After checking printk.h again, I get the idea of the comment.
"pr_fmt()" is more convenient!

Thanks for the reviewing. I will make new patches.

Jian-Hong Pan

\
 
 \ /
  Last update: 2018-11-17 15:55    [W:0.128 / U:3.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site