Messages in this thread | | | Date | Fri, 16 Nov 2018 21:01:09 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH 3/8] kbuild: refactor modversions build rules |
| |
Hi Masahiro
On Thu, Nov 15, 2018 at 05:27:10PM +0900, Masahiro Yamada wrote: > Let $(CC) compile objects into normal files *.o instead of .tmp_*.o > whether CONFIG_MODVERSIONS is enabled or not. This will help simplify > build rules a lot.
Another approach would be to move more of the build stuff to one or a few build scripts.
Using build scripts makes is much easier to add comments and still keep it readable. And when the build logic list a set of serialized actions they thay can be included in a build script nicely.
But that said - I also like the simplifications you made. Everytime you trim the core kbuild files it is a win for readability.
Sam
| |