lkml.org 
[lkml]   [2018]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V10 01/19] block: introduce multi-page page bvec helpers
    > -#define bvec_iter_page(bvec, iter)				\
    > +#define mp_bvec_iter_page(bvec, iter) \
    > (__bvec_iter_bvec((bvec), (iter))->bv_page)
    >
    > -#define bvec_iter_len(bvec, iter) \
    > +#define mp_bvec_iter_len(bvec, iter) \

    I'd much prefer if we would stick to the segment naming that
    we also use in the higher level helper.

    So segment_iter_page, segment_iter_len, etc.

    > + * This helpers are for building sp bvec in flight.

    Please spell out single page, sp is not easy understandable.

    \
     
     \ /
      Last update: 2018-11-16 14:14    [W:4.065 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site