Messages in this thread | | | Date | Fri, 16 Nov 2018 14:13:05 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH V10 01/19] block: introduce multi-page page bvec helpers |
| |
> -#define bvec_iter_page(bvec, iter) \ > +#define mp_bvec_iter_page(bvec, iter) \ > (__bvec_iter_bvec((bvec), (iter))->bv_page) > > -#define bvec_iter_len(bvec, iter) \ > +#define mp_bvec_iter_len(bvec, iter) \
I'd much prefer if we would stick to the segment naming that we also use in the higher level helper.
So segment_iter_page, segment_iter_len, etc.
> + * This helpers are for building sp bvec in flight.
Please spell out single page, sp is not easy understandable.
| |