Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH v2] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call | Date | Fri, 16 Nov 2018 23:42:24 +1100 |
| |
Elvira Khabirova <lineprinter@altlinux.org> writes:
> Arch code should use tracehook_*() helpers, as documented > in include/linux/tracehook.h.
Thanks.
It probably also should have a comment explaining why we're ignoring the return value and why that's OK.
cheers
> Fixes: 5521eb4bca2d ("powerpc/ptrace: Add support for PTRACE_SYSEMU") > Signed-off-by: Elvira Khabirova <lineprinter@altlinux.org> > --- > arch/powerpc/kernel/ptrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c > index afb819f4ca68..d79d907f9acc 100644 > --- a/arch/powerpc/kernel/ptrace.c > +++ b/arch/powerpc/kernel/ptrace.c > @@ -3266,7 +3266,7 @@ long do_syscall_trace_enter(struct pt_regs *regs) > user_exit(); > > if (test_thread_flag(TIF_SYSCALL_EMU)) { > - ptrace_report_syscall(regs); > + (void) tracehook_report_syscall_entry(regs); > /* > * Returning -1 will skip the syscall execution. We want to > * avoid clobbering any register also, thus, not 'gotoing' > -- > 2.19.1
| |