lkml.org 
[lkml]   [2018]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [alsa-devel] [PATCH v3 1/5] ALSA: soc-compress: add support to snd_compr_set_runtime_buffer()
    Hi Srinivas,

    One minor comment:

    <snip>

    > struct snd_compr_ops *ops;
    > + struct snd_dma_buffer *dma_buffer_p;

    I don't think it is necessary to encode the type inside the name variable
    So, dma_buffer would sounds better to me then dma_buffer_p;

    > void *buffer;

    It is also consistent with this ^

    <snip>
    > +static inline void snd_compr_set_runtime_buffer(
    > + struct snd_compr_stream *substream,
    > + struct snd_dma_buffer *bufp)

    Also buf instead of bufp here.

    thanks,
    Daniel.

    \
     
     \ /
      Last update: 2018-11-16 08:19    [W:3.057 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site