Messages in this thread | | | Date | Thu, 15 Nov 2018 11:20:47 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH 4/4] arm64: dts: qcom: msm8998-mtp: Add external SD |
| |
On Thu 15 Nov 09:18 PST 2018, Jeffrey Hugo wrote:
> The externally accessible SD card slot on the MTP is driven by SDCC2. > Wire it up for use. > > Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 13 +++++++++++++ > arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 + > 2 files changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > index b4276da..a90b427 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > @@ -241,3 +241,16 @@ > }; > }; > }; > + > +&sdhc2 { > + status = "okay";
Please fix the indentation of the rest of the properties in this block.
> + cd-gpios = <&tlmm 95 GPIO_ACTIVE_LOW>; > + > + vmmc-supply = <&vreg_l21a_2p95>; > + vqmmc-supply = <&vreg_l13a_2p95>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>; > + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; > +};
With that,
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards, Bjorn
| |