[lkml]   [2018]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] rtc: m41t80: Complete error propagation from SMBus calls
On 07/11/2018 02:39:51+0000, Maciej W. Rozycki wrote:
> Complement commit 85d77047c4ea ("drivers/rtc/rtc-m41t80.c: propagate
> error value from smbus functions") and correct the remaining places that
> fail to propagate the error code from SMBus calls.
> Signed-off-by: Maciej W. Rozycki <>
> References: 85d77047c4ea ("drivers/rtc/rtc-m41t80.c: propagate error value from smbus functions")
> ---
> Hi,
> I think this does not qualify for backporting, but please feel free to
> decide otherwise.
> This change I did verify at run time to the extent I was able to, but I
> didn't try to trigger artificial errors. Also the M41T81, which is the
> device I've been using this driver with, does not have battery failure
> indication implemented, so I could not execute the procfs handling path
> (again without making some artificial changes). These changes should be
> obvious regardless.
> I'll be posting further patches over the coming weeks, based on my
> original effort as archived here: <>,
> <>
> However I have just realised they'll need another iteration before I post
> them. So for now just these two obvious fixes.

Regarding the persistent part, do you really need more than what is
provided? As far as I know, the timekeeping core is already taking care
of using the best source to get the suspended time.

Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering

 \ /
  Last update: 2018-11-14 10:58    [W:0.100 / U:1.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site