[lkml]   [2018]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V7 1/4] blk-mq: refactor the code of issue request directly
Hi Ming

On 11/14/18 5:11 PM, Ming Lei wrote:
>> - if (!blk_mq_get_dispatch_budget(hctx))
>> - goto insert;
>> + if (unlikely(!blk_mq_get_dispatch_budget(hctx)))
>> + goto out_unlock;
> The unlikely annotation is a bit misleading, since out-of-budget can
> happen frequently in case of low queue depth, and there are lots of
> such examples.

This could be good for the case for no .get_budget and getting budget success.
In case of out-of-budget, we insert the request which is slow path.
It should be OK. Maybe some comment should be added for this.


 \ /
  Last update: 2018-11-14 10:24    [W:0.101 / U:2.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site