lkml.org 
[lkml]   [2018]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 0/2] perf tests: Check for ARM [vectors] page
From
Date
On 10/25/18 10:55 AM, Florian Fainelli wrote:
> Hi all,
>
> I just painfully learned that perf would segfault when
> CONFIG_KUSER_HELPERS is disabled because it unconditionally makes use of
> it. This patch series adds an ARM test for that by leveraging the
> existing find_vdso_map() function and making it more generic and capable
> of location any map within /proc/self/maps.

Did not get much feedback, you are all probably busy attending LPC
conferences, but I was wondering if this did make sense or if there is a
better approach that should be looked at?

I am starting to see additional tests failing that require some ARM
(32-bit) specific changes, and not accumulating too many of these fixes
on top of that series would be neat.

Thank you!

>
> Changes in v2:
>
> - use strlen() instead of sizeof() -1 since we made the page name a
> parameter
> - use TEST_OK/TEST_FAIL in lieu of 0/-1
> - added an error message indicating CONFIG_KUSER_HELPERS might be
> disabled
>
> Florian Fainelli (2):
> perf tools: Make find_vdso_map() more modular
> perf tests: Add a test for the ARM 32-bit [vectors] page
>
> tools/perf/arch/arm/tests/Build | 1 +
> tools/perf/arch/arm/tests/arch-tests.c | 4 +++
> tools/perf/arch/arm/tests/vectors-page.c | 24 ++++++++++++++++++
> tools/perf/tests/tests.h | 5 ++++
> tools/perf/util/find-map.c | 31 ++++++++++++++++++++++++
> tools/perf/util/find-vdso-map.c | 30 +++--------------------
> 6 files changed, 68 insertions(+), 27 deletions(-)
> create mode 100644 tools/perf/arch/arm/tests/vectors-page.c
> create mode 100644 tools/perf/util/find-map.c
>


--
Florian

\
 
 \ /
  Last update: 2018-11-13 23:45    [W:0.128 / U:9.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site