lkml.org 
[lkml]   [2018]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 18/25] ARM: davinci: dm644x-evm: use device properties for at24 eeprom
    Date
    From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

    We want to work towards phasing out the at24_platform_data structure.
    There are few users and its contents can be represented using generic
    device properties. Using device properties only will allow us to
    significantly simplify the at24 configuration code.

    Remove the at24_platform_data structure and replace it with an array
    of property entries. Drop the byte_len/size property, as the model name
    already implies the EEPROM's size.

    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    ---
    arch/arm/mach-davinci/board-dm644x-evm.c | 13 +++++--------
    1 file changed, 5 insertions(+), 8 deletions(-)

    diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
    index e1428115067f..efe4e170e87d 100644
    --- a/arch/arm/mach-davinci/board-dm644x-evm.c
    +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
    @@ -16,8 +16,8 @@
    #include <linux/gpio/machine.h>
    #include <linux/i2c.h>
    #include <linux/platform_data/pcf857x.h>
    -#include <linux/platform_data/at24.h>
    #include <linux/platform_data/gpio-davinci.h>
    +#include <linux/property.h>
    #include <linux/mtd/mtd.h>
    #include <linux/mtd/rawnand.h>
    #include <linux/mtd/partitions.h>
    @@ -532,12 +532,9 @@ static struct nvmem_cell_lookup dm644evm_nvmem_cell_lookup = {
    .con_id = "mac-address",
    };

    -static struct at24_platform_data eeprom_info = {
    - .byte_len = (256*1024) / 8,
    - .page_size = 64,
    - .flags = AT24_FLAG_ADDR16,
    - .setup = davinci_get_mac_addr,
    - .context = (void *)0x7f00,
    +static const struct property_entry eeprom_properties[] = {
    + PROPERTY_ENTRY_U32("pagesize", 64),
    + { }
    };

    /*
    @@ -647,7 +644,7 @@ static struct i2c_board_info __initdata i2c_info[] = {
    },
    {
    I2C_BOARD_INFO("24c256", 0x50),
    - .platform_data = &eeprom_info,
    + .properties = eeprom_properties,
    },
    {
    I2C_BOARD_INFO("tlv320aic33", 0x1b),
    --
    2.19.1
    \
     
     \ /
      Last update: 2018-11-13 15:04    [W:4.464 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site