Messages in this thread | | | Date | Tue, 13 Nov 2018 08:28:25 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v4 3/6] mfd: lochnagar: Add initial binding documentation |
| |
On Thu, 08 Nov 2018, Charles Keepax wrote:
> Lochnagar is an evaluation and development board for Cirrus > Logic Smart CODEC and Amp devices. It allows the connection of > most Cirrus Logic devices on mini-cards, as well as allowing > connection of various application processor systems to provide a > full evaluation platform. This driver supports the board > controller chip on the Lochnagar board. > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> > --- > > I have dropped Rob and Stephen's Acks from this patch on > account of the scale of the changes since v3. > > Changes since v3: > - Split the binding up into separate parts for the individual subsystems > - Added documentation for the fixed clocks that are done through DT > > Thanks, > Charles > > .../devicetree/bindings/clock/cirrus,lochnagar.txt | 89 +++++++++++++ > .../devicetree/bindings/mfd/cirrus,lochnagar.txt | 70 ++++++++++
I think these should all be seperate patches.
Code looks okay to me though.
For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |