Messages in this thread | | | Date | Tue, 13 Nov 2018 10:55:53 -0800 | From | Mark Brown <> | Subject | Re: [PATCH] spi: lpspi: Add Slave Mode support for LPSPI |
| |
On Mon, Nov 12, 2018 at 06:47:08AM +0000, Clark Wang wrote:
This looks fine so I'll apply it but it would have been easier to review if it were split up a bit. There's mechanical changes like:
> -static int lpspi_prepare_xfer_hardware(struct spi_master *master) > +static int lpspi_prepare_xfer_hardware(struct spi_controller *controller) > {
...the conversion to controller...
> - temp = fsl_lpspi->txfifosize >> 1 | (fsl_lpspi->rxfifosize >> 1) << 16; > + temp = fsl_lpspi->watermark >> 1 | (fsl_lpspi->watermark >> 1) << 16;
...and this renaming which could be done separately. [unhandled content-type:application/pgp-signature] | |