lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 035/222] x86/fpu: Remove second definition of fpu in __fpu__restore_sig()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

    [ Upstream commit 6aa676761d4c1acfa31320e55fa1f83f3fcbbc7a ]

    Commit:

    c5bedc6847c3b ("x86/fpu: Get rid of PF_USED_MATH usage, convert it to fpu->fpstate_active")

    introduced the 'fpu' variable at top of __restore_xstate_sig(),
    which now shadows the other definition:

    arch/x86/kernel/fpu/signal.c:318:28: warning: symbol 'fpu' shadows an earlier one
    arch/x86/kernel/fpu/signal.c:271:20: originally declared here

    Remove the shadowed definition of 'fpu', as the two definitions are the same.

    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Reviewed-by: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Fixes: c5bedc6847c3b ("x86/fpu: Get rid of PF_USED_MATH usage, convert it to fpu->fpstate_active")
    Link: http://lkml.kernel.org/r/20181016202525.29437-3-bigeasy@linutronix.de
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/x86/kernel/fpu/signal.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/arch/x86/kernel/fpu/signal.c
    +++ b/arch/x86/kernel/fpu/signal.c
    @@ -314,7 +314,6 @@ static int __fpu__restore_sig(void __use
    * thread's fpu state, reconstruct fxstate from the fsave
    * header. Validate and sanitize the copied state.
    */
    - struct fpu *fpu = &tsk->thread.fpu;
    struct user_i387_ia32_struct env;
    int err = 0;


    \
     
     \ /
      Last update: 2018-11-12 00:09    [W:4.093 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site