lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 154/222] ima: fix showing large violations or runtime_measurements_count
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Biggers <ebiggers@google.com>

    commit 1e4c8dafbb6bf72fb5eca035b861e39c5896c2b7 upstream.

    The 12 character temporary buffer is not necessarily long enough to hold
    a 'long' value. Increase it.

    Signed-off-by: Eric Biggers <ebiggers@google.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    security/integrity/ima/ima_fs.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/security/integrity/ima/ima_fs.c
    +++ b/security/integrity/ima/ima_fs.c
    @@ -39,14 +39,14 @@ static int __init default_canonical_fmt_
    __setup("ima_canonical_fmt", default_canonical_fmt_setup);

    static int valid_policy = 1;
    -#define TMPBUFLEN 12
    +
    static ssize_t ima_show_htable_value(char __user *buf, size_t count,
    loff_t *ppos, atomic_long_t *val)
    {
    - char tmpbuf[TMPBUFLEN];
    + char tmpbuf[32]; /* greater than largest 'long' string value */
    ssize_t len;

    - len = scnprintf(tmpbuf, TMPBUFLEN, "%li\n", atomic_long_read(val));
    + len = scnprintf(tmpbuf, sizeof(tmpbuf), "%li\n", atomic_long_read(val));
    return simple_read_from_buffer(buf, count, ppos, tmpbuf, len);
    }


    \
     
     \ /
      Last update: 2018-11-11 23:57    [W:4.296 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site