lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 194/222] soc/tegra: pmc: Fix child-node lookup
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 1dc6bd5e39a29453bdcc17348dd2a89f1aa4004e upstream.

    Fix child-node lookup during probe, which ended up searching the whole
    device tree depth-first starting at the parent rather than just matching
    on its children.

    To make things worse, the parent pmc node could end up being prematurely
    freed as of_find_node_by_name() drops a reference to its first argument.

    Fixes: 3568df3d31d6 ("soc: tegra: Add thermal reset (thermtrip) support to PMC")
    Cc: stable <stable@vger.kernel.org> # 4.0
    Cc: Mikko Perttunen <mperttunen@nvidia.com>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
    Signed-off-by: Thierry Reding <treding@nvidia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/soc/tegra/pmc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/soc/tegra/pmc.c
    +++ b/drivers/soc/tegra/pmc.c
    @@ -1321,7 +1321,7 @@ static void tegra_pmc_init_tsense_reset(
    if (!pmc->soc->has_tsense_reset)
    return;

    - np = of_find_node_by_name(pmc->dev->of_node, "i2c-thermtrip");
    + np = of_get_child_by_name(pmc->dev->of_node, "i2c-thermtrip");
    if (!np) {
    dev_warn(dev, "i2c-thermtrip node not found, %s.\n", disabled);
    return;

    \
     
     \ /
      Last update: 2018-11-11 23:53    [W:2.237 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site