lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 100/141] kbuild: fix kernel/bounds.c W=1 warning
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnd Bergmann <arnd@arndb.de>

    commit 6a32c2469c3fbfee8f25bcd20af647326650a6cf upstream.

    Building any configuration with 'make W=1' produces a warning:

    kernel/bounds.c:16:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]

    When also passing -Werror, this prevents us from building any other files.
    Nobody ever calls the function, but we can't make it 'static' either
    since we want the compiler output.

    Calling it 'main' instead however avoids the warning, because gcc
    does not insist on having a declaration for main.

    Link: http://lkml.kernel.org/r/20181005083313.2088252-1-arnd@arndb.de
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Reported-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Cc: David Laight <David.Laight@ACULAB.COM>
    Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    kernel/bounds.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/kernel/bounds.c
    +++ b/kernel/bounds.c
    @@ -12,7 +12,7 @@
    #include <linux/log2.h>
    #include <linux/spinlock_types.h>

    -void foo(void)
    +int main(void)
    {
    /* The enum constants to put into include/generated/bounds.h */
    DEFINE(NR_PAGEFLAGS, __NR_PAGEFLAGS);
    @@ -22,4 +22,6 @@ void foo(void)
    #endif
    DEFINE(SPINLOCK_SIZE, sizeof(spinlock_t));
    /* End of constants */
    +
    + return 0;
    }

    \
     
     \ /
      Last update: 2018-11-11 23:37    [W:4.039 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site