Messages in this thread Patch in this message | | | From | Ben Hutchings <> | Date | Sun, 11 Nov 2018 19:49:05 +0000 | Subject | [PATCH 3.16 016/366] staging:iio:ade7854: Fix the wrong number of bits to read |
| |
3.16.61-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: John Syne <rodrigosiqueiramelo@gmail.com>
commit 6cef2ab01636b6021044f349df466a97c408ec27 upstream.
Fixes: correctly handle the data size in the read operation for I2C
The function ade7854_i2c_read_reg_32() have to invoke the i2c_master_recv() for read 32 bits values, however, the counter is set to 3 which means 24 bits. This patch fixes the wrong size of 24 bits, to 32 bits.
Signed-off-by: John Syne <john3909@gmail.com> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Fixes: 8d97a5877 ("staging: iio: meter: new driver for ADE7754 devices") Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- drivers/staging/iio/meter/ade7854-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/iio/meter/ade7854-i2c.c +++ b/drivers/staging/iio/meter/ade7854-i2c.c @@ -191,7 +191,7 @@ static int ade7854_i2c_read_reg_32(struc if (ret < 0) goto out; - ret = i2c_master_recv(st->i2c, st->rx, 3); + ret = i2c_master_recv(st->i2c, st->rx, 4); if (ret < 0) goto out;
| |