lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 078/366] ext4: correct endianness conversion in __xattr_check_inode()
    3.16.61-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Biggers <ebiggers@google.com>

    commit 199625098a18a5522b424dea9b122b254c022fc5 upstream.

    It should be cpu_to_le32(), not le32_to_cpu(). No change in behavior.

    Found with sparse, and this was the only endianness warning in fs/ext4/.

    Signed-off-by: Eric Biggers <ebiggers@google.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Reviewed-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/ext4/xattr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ext4/xattr.c
    +++ b/fs/ext4/xattr.c
    @@ -251,7 +251,7 @@ __xattr_check_inode(struct inode *inode,
    int error = -EIO;

    if (((void *) header >= end) ||
    - (header->h_magic != le32_to_cpu(EXT4_XATTR_MAGIC)))
    + (header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)))
    goto errout;
    error = ext4_xattr_check_names(entry, end, entry);
    errout:
    \
     
     \ /
      Last update: 2018-11-11 21:20    [W:5.687 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site