Messages in this thread | | | From | Nick Desaulniers <> | Date | Mon, 12 Nov 2018 10:55:53 -0800 | Subject | Re: [PATCH v2 1/2] Makefile: Export clang toolchain variables |
| |
On Sun, Nov 11, 2018 at 8:21 PM Joel Stanley <joel@jms.id.au> wrote: > > The powerpc makefile will use these in it's boot wrapper. > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile b/Makefile > index 09278330282d..840efe6eb54c 100644 > --- a/Makefile > +++ b/Makefile > @@ -495,6 +495,7 @@ endif > ifneq ($(GCC_TOOLCHAIN),) > CLANG_FLAGS += --gcc-toolchain=$(GCC_TOOLCHAIN) > endif > +export CLANG_FLAGS > CLANG_FLAGS += -no-integrated-as
Does this export CLANG_FLAGS before `-no-integrated-as` is set? Either way, I think it would be clearer to export this after all the relevant flags are set.
> KBUILD_CFLAGS += $(CLANG_FLAGS) > KBUILD_AFLAGS += $(CLANG_FLAGS) > -- > 2.19.1 >
-- Thanks, ~Nick Desaulniers
| |