Messages in this thread | | | Subject | Re: [PATCH net-next] NFC: nci: remove redundant variable 'status' | From | YueHaibing <> | Date | Mon, 12 Nov 2018 21:20:31 +0800 |
| |
Ping.
On 2018/9/13 20:06, YueHaibing wrote: > Ping. > > On 2018/8/1 15:20, YueHaibing wrote: >> After commit d8cd37ed2fc8 ("NFC: nci: Fix improper management of HCI return code") >> variable 'status' is being assigned but never used, >> so can be removed. Also make a trival cleanup. >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> net/nfc/nci/hci.c | 10 ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c >> index ddfc52a..4debba8 100644 >> --- a/net/nfc/nci/hci.c >> +++ b/net/nfc/nci/hci.c >> @@ -370,17 +370,11 @@ static void nci_hci_resp_received(struct nci_dev *ndev, u8 pipe, >> u8 result, struct sk_buff *skb) >> { >> struct nci_conn_info *conn_info; >> - u8 status = result; >> >> conn_info = ndev->hci_dev->conn_info; >> - if (!conn_info) { >> - status = NCI_STATUS_REJECTED; >> - goto exit; >> - } >> - >> - conn_info->rx_skb = skb; >> + if (conn_info) >> + conn_info->rx_skb = skb; >> >> -exit: >> nci_req_complete(ndev, NCI_STATUS_OK); >> } >> >> > > > . >
| |