lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: venus: change the default value of GOP size
From
Date
Hi Malathi,

Thanks for the patch!

On 11/12/18 11:06 AM, Malathi Gottam wrote:
> When the client doesn't explicitly set any GOP size, current
> default value is low and overshoots bitrate beyond tolerance.
> Hence default value is modified so as to have intra period of 1sec.
>
> Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
> ---
> drivers/media/platform/qcom/venus/venc_ctrls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Sounds reasonable :

Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

> diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c b/drivers/media/platform/qcom/venus/venc_ctrls.c
> index 45910172..e6a43e9 100644
> --- a/drivers/media/platform/qcom/venus/venc_ctrls.c
> +++ b/drivers/media/platform/qcom/venus/venc_ctrls.c
> @@ -295,7 +295,7 @@ int venc_ctrl_init(struct venus_inst *inst)
> 0, INTRA_REFRESH_MBS_MAX, 1, 0);
>
> v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
> - V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 12);
> + V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 30);
>
> v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
> V4L2_CID_MPEG_VIDEO_VPX_MIN_QP, 1, 128, 1, 1);
>

--
regards,
Stan

\
 
 \ /
  Last update: 2018-11-12 12:52    [W:0.341 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site