Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 12 Nov 2018 10:00:36 +0100 | Subject | Re: [RFC PATCH 06/13] m68k: Drop ARCH_USES_GETTIMEOFFSET |
| |
Hi Finn,
Thanks for your patch!
On Mon, Nov 12, 2018 at 5:46 AM Finn Thain <fthain@telegraphics.com.au> wrote: > The functions that implement arch_gettimeoffset are re-used by > new clocksource drivers in subsequent patches.
Disabling this first affects functionality during bisection, right?
> --- a/arch/m68k/amiga/config.c > +++ b/arch/m68k/amiga/config.c > @@ -95,8 +95,6 @@ static char amiga_model_name[13] = "Amiga "; > static void amiga_sched_init(irq_handler_t handler); > static void amiga_get_model(char *model); > static void amiga_get_hardware_list(struct seq_file *m); > -/* amiga specific timer functions */ > -static u32 amiga_gettimeoffset(void); > extern void amiga_mksound(unsigned int count, unsigned int ticks); > static void amiga_reset(void); > extern void amiga_init_sound(void); > @@ -386,7 +384,6 @@ void __init config_amiga(void) > mach_init_IRQ = amiga_init_IRQ; > mach_get_model = amiga_get_model; > mach_get_hardware_list = amiga_get_hardware_list; > - arch_gettimeoffset = amiga_gettimeoffset;
In addition, won't this lead to "function defined statically but not called' warnings?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |