lkml.org 
[lkml]   [2018]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 114/361] net: hns3: Preserve vlan 0 in hardware table
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yunsheng Lin <linyunsheng@huawei.com>

    [ Upstream commit daaa8521760ee4d4e65f309c4c37b3a1e58c9d4e ]

    When netdev is down, the stack will delete the vlan from
    hardware including vlan0, which will cause problem when
    doing loopback selftest when netdev is down.

    This patch fixes it by always preserving vlan 0 in hardware,
    because vlan 0 is defalut vlan, which should always be in
    hardware.

    Fixes: c39c4d98dc65 ("net: hns3: Add mac loopback selftest support in hns3 driver")
    Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
    Signed-off-by: Peng Li <lipeng321@huawei.com>
    Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
    @@ -4739,6 +4739,9 @@ static int hclge_set_vlan_filter_hw(stru
    u16 vport_idx, vport_num = 0;
    int ret;

    + if (is_kill && !vlan_id)
    + return 0;
    +
    ret = hclge_set_vf_vlan_common(hdev, vport_id, is_kill, vlan_id,
    0, proto);
    if (ret) {

    \
     
     \ /
      Last update: 2018-11-12 01:11    [W:4.139 / U:1.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site